[12.x] Enum support for Cache::get() with array keys#58616
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Feb 4, 2026
Merged
[12.x] Enum support for Cache::get() with array keys#58616taylorotwell merged 1 commit intolaravel:12.xfrom
taylorotwell merged 1 commit intolaravel:12.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works:
Cache::get(CacheKey::Users)This doesn't:
Someone on my team (@MizouziE) tried this and it didn't work, so thought I'd try a PR.. not sure on your opinion (I know you're sick of these), but felt like it keeps the API consistent, but probably will open a can of worms on array usages...
If you want me to go through all of the array ones, let me know.. (ie
putetc also support arrays) but thought i'd try just these for now to get the ball rolling - but totally understand if you don't fancy it!