[12.x] Allow closures for values in firstOrCreate and createOrFirst#58639
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Feb 5, 2026
Merged
Conversation
GromNaN
added a commit
to mongodb/laravel-mongodb
that referenced
this pull request
Feb 11, 2026
…3479) Declare Query\Builder::timeout() conditionally if not declared in Laravel. Added timeout method to query builder for MySQL laravel/framework#58644 Support value-closure as 2nd argument of createOrFirst and firstOrCreate. Allow closures for values in firstOrCreate and createOrFirst laravel/framework#58639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
firstOrCreate&createOrFirstto accept a closures as the$valuesparameter, so that lazy evaluation of expensive operations are only happening when a record actually needs to be created.The use case
When using
firstOrCreatewith values that involve expensive operations (API calls, encryption) are evaluated eagerly, even when the record already exists and the values are never used.To work around this today, you have to leave
firstOrCreateand split the lookup from the creation:With this PR, you can wrap the values in a closure to defer evaluation while preserving the single call: