[12.x] Add missing @throws annotations to validation rules and JsonResponse#58697
Merged
taylorotwell merged 3 commits intolaravel:12.xfrom Feb 9, 2026
Merged
Conversation
shaedrich
reviewed
Feb 8, 2026
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
@throws \InvalidArgumentExceptionannotations to methods that throw but don't document it:Email::defaults()— throws when callback is not callable or instance of staticPassword::defaults()— same patternFile::defaults()— same patternFile::toKilobytes()— throws on invalid file size suffixRequiredIf::__construct()— throws when condition is not callable or booleanJsonResponse::setData()— throws on JSON encoding errorThese annotations improve IDE support and static analysis by making the exception contracts explicit.