Improve File::toKilobytes() DocBlock return type#58811
Merged
taylorotwell merged 2 commits intolaravel:12.xfrom Feb 14, 2026
Merged
Improve File::toKilobytes() DocBlock return type#58811taylorotwell merged 2 commits intolaravel:12.xfrom
taylorotwell merged 2 commits intolaravel:12.xfrom
Conversation
Replace @return mixed with int|float for better IDE support and type clarity.
shaedrich
reviewed
Feb 14, 2026
Amirhf1
commented
Feb 14, 2026
Contributor
Author
Amirhf1
left a comment
Amirhf1
left a comment
There was a problem hiding this comment.
Done. I've updated the PR with the requested changes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
@return mixedwith@return int|floatfor thetoKilobytes()method in the File validation rule. The method returns either an integer (when$sizeis passed as int) or a float (fromround()when processing string sizes with kb/mb/gb/tb suffixes), so the updated DocBlock better reflects the actual return types and improves IDE support.