Merged
Conversation
Elchi3
added
the
bug
wbamberg
approved these changes
Sep 22, 2017
Contributor
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
This looks fine. I made one improvement suggestion.
test/render.js
Outdated
| } else { | ||
| desc += `<code>${Object.keys(row)[0]}</code>`; | ||
| } | ||
| if (feature.mdn_url) { desc += '</a>'; } |
Contributor
There was a problem hiding this comment.
I think it might be a bit cleaner, instead of having this and line 365, to build desc without the link, then wrap it at the end:
if (feature.mdn_url) {
desc = `<a href="${feature.mdn_url}">${desc}</a>`;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object where
__count__etc. aren't linked, although they have anmdn_url.(yes, we should write exhaustive tests for this code/macro – there are more bugs in here, for sure)