Add compat data for Animation#975
Conversation
Elchi3
added
the
data:api
teoli2003
left a comment
teoli2003
left a comment
There was a problem hiding this comment.
It is already really good! There are two (non-obvious) structures, "alternate_name" and "flags" that allow to describe some of the notes in a machine readable format.
I've marked some occurrences of each.
api/Animation.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/Animation", | ||
| "support": { | ||
| "webview_android": { | ||
| "version_added": "39", |
There was a problem hiding this comment.
Rather than a note, we can describe this using"alternate_name
"webview_android": [
{
"version_added": "44"
},
{
"alternate_name": "AnimationPlayer",
"version_added": "39",
"version_removed": "44"
}
]
(indentation not necessarily correct)
api/Animation.json
Outdated
| }, | ||
| "firefox": { | ||
| "version_added": "48", | ||
| "notes": "The Web Animations API is only enabled by default in Firefox Developer Edition and Nightly builds. You can enable it in release builds by setting the preference <code>dom.animations-api.core.enabled</code> to <code>true</code>, and can disable it in any Firefox version by setting this preference to <code>false</code>." |
There was a problem hiding this comment.
This has to be described using the "flags", the schema documentation has examples.
There was a problem hiding this comment.
I'll do this all in a bit - thank you! 😄
|
@CalmBit This is already really good! There are two concepts you didn't know, and after that we will need to make a second pass of review to check the details, but we are very close to be landing this. Good Job! Thank you a lot for your help. |
|
Alright, there's at least some of them converted - I wasn't so sure about things like different versions returning different values from other calls, so I left those alone. Was there any path you'd suggest for them? |
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
This looks good to me now, well done!
If you're interested, I think some of the Firefox version numbers could be corrected here as a follow-up. Some info might be wrong in the current tables. There is https://birtles.github.io/areweanimatedyet/ with details and links to bugs where features got implemented. I think it got enabled by default without the flag in Firefox 48, but individual members got implemented behind the flag in earlier versions.
But as our main focus is just getting the current info migrated, this is all good for now :) Thanks again!
|
#1052 should be the first step to addressing most of that data! |
3 participants
Adding compat data for Animation (https://developer.mozilla.org/en-US/docs/Web/API/Animation)
😄