Skip to content

fix: not mark required aria attributes as required#42276

Merged
dipikabh merged 3 commits intomdn:mainfrom
mehm8128:aria-not-required-attributes
Feb 17, 2026
Merged

fix: not mark required aria attributes as required#42276
dipikabh merged 3 commits intomdn:mainfrom
mehm8128:aria-not-required-attributes

Conversation

@mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Dec 7, 2025

Description

unmarked not required aria attributes as required.

Motivation

Because aria-selected for option role and aria-valuenow for spinbutton role are not required and both roles have default values for their attributes.

https://www.w3.org/TR/wai-aria-1.2/#spinbutton

Authors SHOULD set the aria-valuenow attribute when the spinbutton has a value.

(->not MUST)

Default for aria-valuenow is 0

https://www.w3.org/TR/wai-aria-1.2/#option

Elements with the role option have an implicit aria-selected value of false.

Default for aria-selected is false.

Additional details

Related issues and pull requests

@mehm8128 mehm8128 requested a review from a team as a code owner December 7, 2025 15:26
@mehm8128 mehm8128 requested review from scottohara and removed request for a team December 7, 2025 15:26
@github-actions github-actions bot added Content:Accessibility Accessibility docs size/xs [PR only] 0-5 LoC changed labels Dec 7, 2025
@mehm8128 mehm8128 force-pushed the aria-not-required-attributes branch from 555e297 to 9e70811 Compare December 23, 2025 03:08
@mehm8128 mehm8128 force-pushed the aria-not-required-attributes branch from 9e70811 to c47fcbc Compare January 9, 2026 15:25
@mehm8128 mehm8128 force-pushed the aria-not-required-attributes branch from c47fcbc to d66a80f Compare January 17, 2026 02:52
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

@mehm8128 mehm8128 force-pushed the aria-not-required-attributes branch from d66a80f to 510ccd0 Compare February 13, 2026 00:02
@mehm8128 mehm8128 requested a review from a team as a code owner February 13, 2026 00:02
@mehm8128 mehm8128 requested review from dipikabh and removed request for a team February 13, 2026 00:02
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehm8128 thanks for sending these updates.
I have a few more suggestions to match these changes.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Feb 15, 2026
@mehm8128
Copy link
Contributor Author

@dipikabh
Thank you! I fixed them.

@mehm8128 mehm8128 requested a review from dipikabh February 15, 2026 07:16
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mehm8128!
Merging now

@dipikabh dipikabh merged commit f6e12d0 into mdn:main Feb 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Accessibility Accessibility docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments