This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Clean up appearance of list-style-type example#601
Merged
wbamberg merged 2 commits intomdn:masterfrom Feb 22, 2018
Merged
Conversation
schalkneethling
suggested changes
Feb 22, 2018
schalkneethling
left a comment
schalkneethling
left a comment
There was a problem hiding this comment.
One small change required. Thanks @ddbeck
| suffix: " " | ||
| }</code></pre> | ||
| </div> | ||
| <div class="note"><p><code>space-counter</code> is defined with <a href="https://developer.mozilla.org/docs/Web/CSS/%40counter-style"><code>@counter-style</code></a></p> |
There was a problem hiding this comment.
Oh wait, seeing that this will be in an iframe, the anchor will need target="_parent", else this will load inside the iframe. Also, the URL need to be preceded with // else it will "inherit" the domain of the iframe.
Lastly, it seems like MDN is not playing nice with the encoded @ symbol so, perhaps make the URL //developer.mozilla.org/docs/Web/CSS/@counter-style
Contributor
Author
|
Fixed the link. Thank you @schalkneethling! |
wbamberg
approved these changes
Feb 22, 2018
Contributor
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
Looks great @ddbeck ! @schalkneethling , thanks for the review, I would not have caught that. I've tested this in an iframe and it works fine.
wbamberg
pushed a commit
that referenced
this pull request
Feb 22, 2018
This reverts commit 785633b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from the conversation on #594, this removes the complicated description of
@counter-stylein thelist-style-typeexample.