This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Revert "Adds next iteration of the HTML interactive editor"#604
Closed
Revert "Adds next iteration of the HTML interactive editor"#604
Conversation
added 2 commits
February 22, 2018 12:07
Contributor
Author
|
Oh, this also revert 785633b, which I wasn't expecting. |
Contributor
|
Should this commit be included? Auto run on load, and change Run to Update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #576
I believe this change breaks the CSS examples. I think it's due to this line: https://github.com/mdn/interactive-examples/blob/master/js/editor-libs/tabby.js#L3, which assumes the previous line does not return
null- but it does, I guess because the HTML editor is not defined in CSS examples.So the example looks like this: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow?v=b