Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

Update data types and add special cases#330

Merged
Elchi3 merged 1 commit intomdn:masterfrom
mfluehr:patch-2
Sep 29, 2017
Merged

Update data types and add special cases#330
Elchi3 merged 1 commit intomdn:masterfrom
mfluehr:patch-2

Conversation

@mfluehr
Copy link
Contributor

@mfluehr mfluehr commented Sep 26, 2017

No description provided.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works great!

(Conceptually, I think that this macro is non-sense, it is only used in 2 pages and we could just have this as normal wiki text).

@Elchi3 Elchi3 merged commit 881396c into mdn:master Sep 29, 2017
@mfluehr
Copy link
Contributor Author

mfluehr commented Sep 30, 2017

@Elchi3 Yes, I see what you mean about this macro as a whole. If you like, I can replace the list on "CSS basic data types" with a more standard "index" list, like is used on most Overview pages. (I don't think it's really necessary at all on "<translation-value>".)

Is there a process for deprecating oddball macros like this one, to prevent MDN authors from using them?

@Elchi3
Copy link
Member

Elchi3 commented Oct 2, 2017

Yes, I think I would be very much in favor of replacing this macro with just a plain list. That way authors can edit it in the wiki directly and no script change and script deployment is needed in the future.

Is there a process for deprecating oddball macros like this one, to prevent MDN authors from using them?

  1. Find pages that call a macro, like for this one it is used on 2 pages only .
  2. Open a Pull Request here in mdn/kumascript to remove the macro file (CSSDataTypes.ejs)
  3. Once there was a deployment getting the latest version of mdn/kumascript into MDN production, the macro will no longer work and MDN authors can't use it anymore.

@mfluehr mfluehr mentioned this pull request Oct 2, 2017
@mfluehr mfluehr deleted the patch-2 branch October 2, 2017 14:10
jwhitlock added a commit to mdn/kuma that referenced this pull request Oct 3, 2017
* mdn/kumascript#327 - SpecName: Add Web Share API
* mdn/kumascript#328 - spec2: Add Web Share API
* mdn/kumascript#329 - CSS_Ref: fix transform-function
* mdn/kumascript#330 - CSSDataTypes: Updates and special cases
* mdn/kumascript#334 - spec2: EME is REC
* mdn/kumascript#336 - spec2: Update values list
* mdn/kumascript#337 - delete CSSDataTypes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants