This repository was archived by the owner on Jun 21, 2022. It is now read-only.
adding Forms module to learnsidebar macro#331
Merged
Elchi3 merged 2 commits intomdn:masterfrom Sep 29, 2017
chrisdavidmills:add-forms-to-learnsidebar
Merged
adding Forms module to learnsidebar macro#331Elchi3 merged 2 commits intomdn:masterfrom chrisdavidmills:add-forms-to-learnsidebar
Elchi3 merged 2 commits intomdn:masterfrom
chrisdavidmills:add-forms-to-learnsidebar
Conversation
Elchi3
approved these changes
Sep 29, 2017
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
r+ with the one glitch addressed.
macros/LearnSidebar.ejs
Outdated
| 'HTML_forms_in_legacy_browsers' : 'HTML forms in legacy browsers', | ||
| 'Styling_HTML_forms' : 'Styling HTML forms', | ||
| 'Advanced_styling_for_HTML_forms' : 'Advanced styling for HTML forms', | ||
| 'Property_compatibility_table_for_form_widgets' : 'Property_compatibility_table_for_form_widgets', |
Member
There was a problem hiding this comment.
No underscores in the value here.
Contributor
Author
|
Ooops. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done some work to get it looking in much better shape than it was, therefore I think it is ready to share more widely now.