Skip to content

Fix some PX4 issues with latest master branch #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
madratman merged 3 commits into from
Apr 30, 2020
Merged

Fix some PX4 issues with latest master branch #2634

madratman merged 3 commits into from
Apr 30, 2020

Conversation

@lovettchris
Copy link
Member

@lovettchris lovettchris commented Apr 29, 2020

Fix memory corruption in setThreadName helper function.
Print message when home GPS location is set.
Delay connecting UDP connection to avoid socket errors.

@lovettchris
help folks migrate to 4.24.
64bb8bc
@lovettchris
PX4 bug fixes.
c8fb074 
Fix macos build relating to setThreadName helper function.
Print message when home GPS location is set.
Delay connecting UDP connection to avoid socket errors.
@lovettchris lovettchris mentioned this pull request Apr 29, 2020
Closed
@rajat2004
Copy link
Contributor

rajat2004 commented Apr 29, 2020

One thing which I had noticed sometime back is that PX4 is using the system clock for sending the simulation time. This is in contrast to in Ardupilot where the stepped time is being used

I really have no idea whether this causes any effect or anything, just though I should post my doubt

@lovettchris
Copy link
Member Author

lovettchris commented Apr 29, 2020

Interesting question about the clock, I'll ping my PX4 friends and see if the actual time delta between ticks makes any difference when PX4 is running in lockstep mode. I doubt it will, but I'll check, thanks.

@lovettchris lovettchris requested a review from madratman April 29, 2020 21:37
@lovettchris lovettchris mentioned this pull request Apr 29, 2020
Closed
@madratman
Copy link
Contributor

madratman commented Apr 30, 2020 •
edited
Loading

This seems to be working well with master, v1.11.0-beta1, v1.10.1. Thanks Chris! @TomSeestern, @bys1123, it would be great if you guys can give it a shot as well. (I haven't tried sending cmds with QGC). Just observing the terminal output

@madratman madratman merged commit 39b8e56 into master Apr 30, 2020
@lovettchris lovettchris deleted the clovett/vs2019 branch April 30, 2020 01:11
@bys1123
Copy link
Contributor

bys1123 commented Apr 30, 2020 •
edited
Loading

Thanks your great works!
cc' @Jaeyoung-Lim @MaEtUgR
Related issues: PX4/PX4-Autopilot#14615 #2477

@lovettchris lovettchris mentioned this pull request May 1, 2020
Closed
@bys1123 bys1123 mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madratman madratman Awaiting requested review from madratman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lovettchris @rajat2004 @madratman @bys1123