Skip to content

Comments

Only using the kubelet flag allow-privileged for versions < 1.15#383

Merged
madhanrm merged 2 commits intomicrosoft:masterfrom
wk8:wk8/privileged_flag_deprecated
Aug 6, 2019
Merged

Only using the kubelet flag allow-privileged for versions < 1.15#383
madhanrm merged 2 commits intomicrosoft:masterfrom
wk8:wk8/privileged_flag_deprecated

Conversation

@wk8
Copy link
Contributor

@wk8 wk8 commented Jul 10, 2019

Since that flag got deprecated in version 1.15, and the kubelet won't
start if it's present.

Fixes #379

Since that flag got deprecated in version 1.15, and the kubelet won't
start if it's present.

Fixes microsoft#379
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
@dhirschfeld
Copy link

It would be great if this could be merged since 1.15 has been released a month ago.

I've always found it better to merge quickly and iterate. If there are new bugs they'll be fixed quickly due to the increased pace of development and they can't be worse than the current situation of being completely broken for k8s 1.15.

@dhirschfeld
Copy link

ping!

@szb640
Copy link

szb640 commented Aug 6, 2019

Any update on the pull request? Following the steps in the Kubernetes' official guide are not working, but should (emphasis mine):

Get the latest binaries from https://github.com/kubernetes/kubernetes/releases, starting with v1.14 or later

@wk8
Copy link
Contributor Author

wk8 commented Aug 6, 2019

Maybe @madhanrm could take a look? :)

@madhanrm
Copy link
Contributor

madhanrm commented Aug 6, 2019

@daschott can you take a look?

@daschott
Copy link
Contributor

daschott commented Aug 6, 2019

@madhanrm Sure, I heard this is set in config file like the comment indicates. I will validate now.

@daschott
Copy link
Contributor

daschott commented Aug 6, 2019

LGTM, validated on 1.13 and 1.15. @madhanrm can you merge?

@madhanrm madhanrm merged commit dbea494 into microsoft:master Aug 6, 2019
@wk8
Copy link
Contributor Author

wk8 commented Aug 7, 2019

Thank you! :)

@wk8 wk8 deleted the wk8/privileged_flag_deprecated branch August 7, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove flag "--allow-privileged" form start-kubelet.ps1 in Kubernetes 1.15

5 participants