configurePlugins command for tsserver#28106
Merged
minestarks merged 3 commits intomicrosoft:release-3.1from Oct 29, 2018
Merged
configurePlugins command for tsserver#28106minestarks merged 3 commits intomicrosoft:release-3.1from
minestarks merged 3 commits intomicrosoft:release-3.1from
Conversation
mjbvz
approved these changes
Oct 24, 2018
Contributor
mjbvz
left a comment
There was a problem hiding this comment.
API changes for server and plugins look good! Just let me know how you want us to expose this on the VS Code side
Member
Author
|
@mjbvz Thanks! Just opened corresponding PR microsoft/vscode#61756 , let me know if that works. |
Member
|
Changes look good but we need test. |
|
Thanks |
2dd7960 to
2e4fe43
Compare
Member
Author
|
@sheetalkamat test added! |
2e4fe43 to
db914d8
Compare
Member
|
Build failed with api |
sheetalkamat
approved these changes
Oct 29, 2018
minestarks
added a commit
to minestarks/TypeScript
that referenced
this pull request
Oct 29, 2018
configurePlugins command for tsserver
minestarks
added a commit
that referenced
this pull request
Oct 29, 2018
Merge pull request #28106 from minestarks/configure-plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #18604
configurePlugins.PluginModule,onConfigurationChanged. Plugin authors can implement this.configurePluginsis invoked, it will pass on the configuration object to any loaded plugin instances with a matching name.create/PluginCreateInfoas well as any previous configurations passed in inconfigurePlugins.createcall, to any projects loaded in the future with the matching plugin. This is needed for consistency -- the caller ofconfigurePluginswould have no way of knowing whether the plugin/project of interest has yet been loaded.cc @mjbvz