"No repeated property names" error in object literals is duplicated in strict mode#46929
Merged
sandersn merged 2 commits intomicrosoft:mainfrom Dec 6, 2021
Merged
"No repeated property names" error in object literals is duplicated in strict mode#46929sandersn merged 2 commits intomicrosoft:mainfrom
sandersn merged 2 commits intomicrosoft:mainfrom
Conversation
2547d20 to
961f92f
Compare
Contributor
Author
|
master is failing as well 🤔 |
sandersn
requested changes
Dec 3, 2021
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks good, just need to fix indentation. (And I hope the build is no longer broken, you might have to merge from main to get that.)
9e07b1f to
c20bcc4
Compare
Contributor
Author
|
@sandersn thank you for the reviews! |
sandersn
approved these changes
Dec 6, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…n strict mode (microsoft#46929) * "No repeated property names" error in object literals is duplicated in strict mode * fix indent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improved the error messages when object property name is duplicated.
smaple
before
now
this is my first pr to this project.
Let me know if there is anything I am missing 😄
Fixes #46815