Add stepping granularities to the step requests.#112
Add stepping granularities to the step requests.#112weinand merged 3 commits intomicrosoft:gh-pagesfrom
Conversation
This allows step requests (Next, StepInto, StepOut, StepBack) to take an optional 'steppingGranularity', which provides a hint for how far a debug adapter should let the step go.
|
@weinand - PR for stepping granularities proposal. |
weinand
left a comment
weinand
left a comment
There was a problem hiding this comment.
Overall looks good to me.
Having descriptions on the 3 stepping values would be nice.
debugAdapterProtocol.json
Outdated
| "SteppingGranularity": { | ||
| "type": "string", | ||
| "description": "The granularity of the requested step.", | ||
| "enum": [ "statement", "line", "instruction" ] |
There was a problem hiding this comment.
Please add descriptions for the individual values (by means of an "enumDescriptions" array).
There was a problem hiding this comment.
Added.
I noticed that the comments weren't getting added to specification.md so I also went ahead and updated the generator to add comments for standalone enum definitions. It added comments on a couple of other places as well. I can also revert those changes if you'd prefer to leave it as is for now (or to handle it separately).
There was a problem hiding this comment.
Reverted for now - was not quite as simple as I initially thought.
The generator also was not adding comments for standalone enum definitions, so this updates the generator to comment these as well.
auott
force-pushed
the
steppingGranularity
branch
from
4ed5300 to
e13f7fc
Compare
|
@auott thanks a lot for the PR. |
3 participants
This allows step requests (Next, StepInto, StepOut, StepBack) to take
an optional 'steppingGranularity', which provides a hint for how far
a debug adapter should let the step go.
This provides support for proposal #110