Add NetCoreDbg to Debug Adapter Protocol implementors list#9
Merged
weinand merged 1 commit intomicrosoft:gh-pagesfrom Nov 2, 2018
Merged
Add NetCoreDbg to Debug Adapter Protocol implementors list#9weinand merged 1 commit intomicrosoft:gh-pagesfrom
weinand merged 1 commit intomicrosoft:gh-pagesfrom
Conversation
mickaelistria
suggested changes
Oct 17, 2018
_implementors/adapters.md
Outdated
| [React Native Tools](https://marketplace.visualstudio.com/items?itemName=vsmobile.vscode-react-native)|[@MSLaguana](https://github.com/MSLaguana)|[Microsoft/vscode-react-native](https://github.com/Microsoft/vscode-react-native/issues) | ||
| [Ruby](https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby)|[@rebornix](https://github.com/rebornix)|[rubyide/vscode-ruby](https://github.com/rubyide/vscode-ruby) | ||
| [SWF](https://marketplace.visualstudio.com/items?itemName=bowlerhatllc.vscode-nextgenas)|[@joshtynjala](https://github.com/joshtynjala)|[BowlerHatLLC/vscode-nextgenas](https://github.com/BowlerHatLLC/vscode-nextgenas) | ||
| [NetCoreDbg](https://github.com/Samsung/netcoredbg)|[@ayuckhulk](https://github.com/ayuckhulk)|[Samsung/netcoredbg](https://github.com/Samsung/netcoredbg) |
There was a problem hiding this comment.
Should this say the framework/language instead of the the name. So it shoud be
[.NET Core](https://github.com/Samsung/netcoredbg)|[@ayuckhulk](https://github.com/ayuckhulk)|[Samsung/netcoredbg](https://github.com/Samsung/netcoredbg)
Contributor
Author
There was a problem hiding this comment.
I am not sure. But in your example the .NET Core link should point to https://github.com/dotnet/coreclr instead of netcoredbg. Maybe just Debugger for .NET Core?
There was a problem hiding this comment.
Yes "Debugger for .NET Core" seems fine as similar pattern is already used in other lines.
ayuckhulk
force-pushed
the
add-netcoredbg
branch
from
3a25cb8 to
4ff512f
Compare
Contributor
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.