This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Use CloseButton on Popular applications page#2323
Merged
Conversation
AmelBawa-msft
approved these changes
Feb 27, 2024
tools/SetupFlow/DevHome.SetupFlow/Views/PackageCatalogListView.xaml
Outdated
Show resolved
Hide resolved
krschau
force-pushed
the
user/krschau/allpackages-close
branch
2 times, most recently
from
8d867ee to
799362a
Compare
krschau
force-pushed
the
user/krschau/allpackages-close
branch
from
799362a to
d4d198e
Compare
vineeththomasalex
approved these changes
Feb 28, 2024
krschau
added
Do-Not-Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Close Button on the Popular Applications page didn't have an accessible name. Use CloseButton control instead, which does set the name.
CloseButton font size is slightly larger (14 vs 12) but matches all other CloseButtons in Dev Home.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49012933
PR checklist