Disable Hyper-V extension on ARM

[huzaifa-d]

Summary of the pull request

Disable config and creation flow for Hyper-V extension on ARM.

Validation steps performed

Tested on an ARM machine

PR checklist

• Closes Hyper-V features should be disabled in ARM devices #2783
• Tests added/passed
• Documentation updated

[dkbennett]

Approve, but have a design question that I don't think should block the PR.

[krschau]

nit

Suggested change

	Log.Information("Disabling Hyper-V extension on ARM {Architecture}", arch);
	Log.Information($"Disabling Hyper-V extension on ARM {arch}");

[sshilov7]

Note: it may be possible to run x86 or x64 DevHome on ARM64EC devices. We don't install those architectures, but users could force it or architectures we build can change in the future. It would be more correct to check device architecture instead of running process architecture.

[huzaifa-d]

Changed

[bbonaby]

Would it be simpler to just remove the ComputeSystemOperations.ApplyConfiguration from the switch statements and then add it at the end in line 150? This way you can just do return supportedOperations so something like this:

Suggested change

	var supportedOperations = ComputeSystemOperations.ApplyConfiguration;
	var revertOperation = Guid.Empty.Equals(ParentCheckpointId) ? ComputeSystemOperations.None : ComputeSystemOperations.RevertSnapshot;
	switch (GetState())
	{
	case ComputeSystemState.Running:
	// Supported operations when running
	return ComputeSystemOperations.ShutDown |
	supportedOperations = ComputeSystemOperations.ShutDown |
	ComputeSystemOperations.Terminate |
	ComputeSystemOperations.Save |
	ComputeSystemOperations.Pause |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.Restart |
	ComputeSystemOperations.ApplyConfiguration |
	revertOperation;
	break;
	case ComputeSystemState.Stopped:
	// Supported operations when stopped
	return ComputeSystemOperations.Start |
	supportedOperations = ComputeSystemOperations.Start |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.Delete |
	ComputeSystemOperations.ApplyConfiguration;
	break;
	case ComputeSystemState.Saved:
	// Supported operations when saved
	return ComputeSystemOperations.Start |
	supportedOperations = ComputeSystemOperations.Start |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.Delete |
	ComputeSystemOperations.ApplyConfiguration |
	revertOperation;
	break;
	case ComputeSystemState.Paused:
	// Supported operations when paused
	return ComputeSystemOperations.Terminate |
	supportedOperations = ComputeSystemOperations.Terminate |
	ComputeSystemOperations.Save |
	ComputeSystemOperations.Resume |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.ApplyConfiguration |
	revertOperation;
	break;
	}
	// Before applying the configuration we start the VM. So we will allow the ApplyConfiguration to be the base supported operation
	// for the VM.
	return ComputeSystemOperations.ApplyConfiguration;
	// Disable ApplyConfiguration for ARM
	var arch = RuntimeInformation.ProcessArchitecture;
	if (arch == Architecture.Arm64 || arch == Architecture.Arm || arch == Architecture.Armv6)
	{
	supportedOperations &= ~ComputeSystemOperations.ApplyConfiguration;
	}
	return supportedOperations;
	var supportedOperations = ComputeSystemOperations.None;
	var revertOperation = Guid.Empty.Equals(ParentCheckpointId) ? ComputeSystemOperations.None : ComputeSystemOperations.RevertSnapshot;
	switch (GetState())
	{
	case ComputeSystemState.Running:
	// Supported operations when running
	supportedOperations = ComputeSystemOperations.ShutDown |
	ComputeSystemOperations.Terminate |
	ComputeSystemOperations.Save |
	ComputeSystemOperations.Pause |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.Restart |
	revertOperation;
	break;
	case ComputeSystemState.Stopped:
	// Supported operations when stopped
	supportedOperations = ComputeSystemOperations.Start |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.Delete;
	break;
	case ComputeSystemState.Saved:
	// Supported operations when saved
	supportedOperations = ComputeSystemOperations.Start |
	ComputeSystemOperations.CreateSnapshot |
	ComputeSystemOperations.Delete |
	revertOperation;
	break;
	case ComputeSystemState.Paused:
	// Supported operations when paused
	supportedOperations = ComputeSystemOperations.Terminate |
	ComputeSystemOperations.Save |
	ComputeSystemOperations.Resume |
	ComputeSystemOperations.CreateSnapshot |
	revertOperation;
	break;
	}
	// Disable ApplyConfiguration for ARM
	var arch = RuntimeInformation.ProcessArchitecture;
	if (arch == Architecture.Arm64 || arch == Architecture.Arm || arch == Architecture.Armv6)
	{
	return supportedOperations;
	}
	return supportedOperations | ComputeSystemOperations.ApplyConfiguration;

[sshilov7]

Coding guidelines: "Use parentheses to make clauses in an expression apparent."