This repository was archived by the owner on Jun 5, 2025. It is now read-only.
CI Build Fix#3169
Merged
ssparach merged 3 commits intofeature/fileexplorer-sourcecontrol-integrationfrom Jun 7, 2024
Merged
Conversation
DefaultRyan
suggested changes
Jun 6, 2024
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepoStoreOptions.cs
Outdated
Show resolved
Hide resolved
ssparach
commented
Jun 6, 2024
...ome.FileExplorerSourceControlIntegration/DevHome.FileExplorerSourceControlIntegration.csproj
Outdated
Show resolved
Hide resolved
DefaultRyan
suggested changes
Jun 6, 2024
...ome.FileExplorerSourceControlIntegration/DevHome.FileExplorerSourceControlIntegration.csproj
Outdated
Show resolved
Hide resolved
DefaultRyan
approved these changes
Jun 7, 2024
ssparach
added a commit
that referenced
this pull request
Jul 31, 2024
* fix * move nullable property in csproj * fix format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Enable nullable property in relevant classes
References and relevant issues
Detailed description of the pull request / Additional comments
Resolves below errors observed in CI builds:
"D:\a\devhome\devhome\DevHome.sln" (default target) (1) ->
"D:\a\devhome\devhome\src\DevHome.csproj.metaproj" (default target) (2) ->
"D:\a\devhome\devhome\src\DevHome.csproj" (default target) (11) ->
"D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj" (default target) (15:2) ->
(CoreCompile target) ->
D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\Services\RepositoryTracking.cs(32,80): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj]
D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\Services\RepositoryTracking.cs(34,37): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj]
D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\Services\RepoStoreOptions.cs(20,19): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a\devhome\devhome\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj]
Validation steps performed
Local Builds (both VS and using build script in Developer Command Prompt to build msix release) are successful
PR checklist