This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add information button name and TeachingTip narrations to Review and Finish page#3497
Merged
lauren-ciha merged 2 commits intomainfrom Jul 31, 2024
Merged
Conversation
Contributor
|
Member
Author
When I had just IsLightDismissEnabled set to false, the Subtitle wasn't read: subtitle_teachingtip_bug.mp4I found that the Subtitles weren't narrated in the WinUI 3 Gallery as well. I'm not sure if that's by design. I mentioned this in the winui-xaml issue so their team is aware of it. |
guimafelipe
approved these changes
Jul 30, 2024
dhoehna
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds two missing narrations to the Review and Finish page:
The information button next to the "Generate Configuration file" button
Before:
before_info_icon_name_change.mp4
After changes:
info_button_narration.mp4
The information button's TeachingTip content
Before:
before_info_icon_changes.mp4
After changes:
info_button_tip_narration.mp4
References and relevant issues
Resolves:
Works around:
Detailed description of the pull request / Additional comments
I had to use a workaround to make the TeachingTip text readable:
Although the workaround makes some minor cosmetic changes, I believe those are worth the additional functionality until the WinUI 3 TeachingTip is updated.
Validation steps performed
PR checklist