Allow MarkupContent[] to be used as Hover contents#572
Closed
DJMcNab wants to merge 1 commit intomicrosoft:gh-pagesfrom
Closed
Allow MarkupContent[] to be used as Hover contents#572DJMcNab wants to merge 1 commit intomicrosoft:gh-pagesfrom
DJMcNab wants to merge 1 commit intomicrosoft:gh-pagesfrom
Conversation
Author
|
Interestingly, |
DJMcNab
added a commit
to DJMcNab/vscode-languageserver-node
that referenced
this pull request
Nov 21, 2018
Author
|
Closing after discussion with @dbaeumer in microsoft/vscode-languageserver-node#417. Note that Sourcegraph uses css rules to make the markdown content with horizontal seperators look the same as multiple array items: sourcegraph/codeintellify@2ab2bf6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #518 and microsoft/vscode-languageserver-node#374.
Supported by microsoft/vscode-languageserver-node#417