Remove "non-empty string" comment for workspace/symbol#770
Closed
DanTup wants to merge 1 commit intomicrosoft:gh-pagesfrom
Closed
Remove "non-empty string" comment for workspace/symbol#770DanTup wants to merge 1 commit intomicrosoft:gh-pagesfrom
DanTup wants to merge 1 commit intomicrosoft:gh-pagesfrom
Conversation
VS Code sends empty strings to LSP servers here to get a full symbol list. Based on discussion at microsoft/vscode-languageserver-node#458 I believe that the VS Code behaviour is desired and the spec is incorrect (the original intention was designed to avoid clients accidentally requesting all symbols before the user had typed, but it seems leaving that to the server is the best option).
This was referenced Jun 10, 2019
dbaeumer
added a commit
that referenced
this pull request
Sep 20, 2019
Member
|
Merged into dbaeumer/3.15 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS Code sends empty strings to LSP servers here to get a full symbol list. Based on discussion at microsoft/vscode-languageserver-node#458 I believe that the VS Code behaviour is desired and the spec is incorrect (the original intention was designed to avoid clients accidentally requesting all symbols before the user had typed, but it seems leaving that to the server is the best option).