This repository was archived by the owner on Nov 5, 2021. It is now read-only.
fix(workerManager.js) : Added a check for the existence of the worker#15
Merged
alexdima merged 1 commit intomicrosoft:mainfrom Aug 17, 2021
Pranomvignesh:check-worker
Merged
fix(workerManager.js) : Added a check for the existence of the worker#15alexdima merged 1 commit intomicrosoft:mainfrom Pranomvignesh:check-worker
alexdima merged 1 commit intomicrosoft:mainfrom
Pranomvignesh:check-worker
Conversation
… before calling withSyncedResources
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description about the issue
monaco-editor-version : 0.25.2
OS : Mac OS
Browser : Chrome
In my application there are 2 instances of monaco editor and when I create the second instance it was throwing this kind of error ( I'm not sure about the proper origin of this issue )
Upon checking in I found a similar issue microsoft/monaco-editor#1254
I found a similar check in monaco-typescript microsoft/monaco-typescript@e4ab9e4#diff-871939a01a574ea561538fe0d1a0d69d238662de6f7bd102d3a1b2a1212f7a5bR120
So I have added a similar check to monaco-html