Set logger for driver API #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1107 +/- ##
==========================================
- Coverage 76.92% 76.72% -0.20%
==========================================
Files 25 25
Lines 7424 7417 -7
==========================================
- Hits 5711 5691 -20
- Misses 1713 1726 +13 |
v-mabarw
previously approved these changes
Mar 24, 2020
Contributor
v-mabarw
left a comment
v-mabarw
left a comment
There was a problem hiding this comment.
Looks good, just noticed a few minor things.
| @@ -0,0 +1,56 @@ | |||
| --TEST-- | |||
| Tset functions return FALSE for errors with logging | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Tset functions return FALSE for errors with logging | |
| Test functions return FALSE for errors with logging |
| @@ -0,0 +1,49 @@ | |||
| --TEST-- | |||
| Tset functions return FALSE for errors with logging | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Tset functions return FALSE for errors with logging | |
| Test functions return FALSE for errors with logging |
source/sqlsrv/conn.cpp
Outdated
| SQLSRV_ASSERT( conn != NULL, "sqlsrv_conn_dtor: connection was null"); | ||
|
|
||
| SET_FUNCTION_NAME( *conn ); | ||
| conn->set_func("sqlsrv_conn_dtor"); |
Contributor
There was a problem hiding this comment.
Would _FN_ work here as well?
Contributor
Author
There was a problem hiding this comment.
Not this one because the macro LOG_FUNCTION is commented but I can certainly use __func__
Thanks :)
David-Engel
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.