Odbc 172 update for connres and appveyor #814
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #814 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 25 25
Lines 7325 7325
=======================================
Hits 5865 5865
Misses 1460 1460Continue to review full report at Codecov.
|
yitam
left a comment
yitam
left a comment
There was a problem hiding this comment.
For pdo ae tests, pls use skipif_mid-refactor.inc instead. Also, for your checks against 2k16 or 2k14, please check how isAEQualified() is implemented to include Azure DB.
yitam
left a comment
yitam
left a comment
There was a problem hiding this comment.
Please consider rewriting the 2k14 and 2k16 skipifs
| <?php require('skipif_mid-refactor.inc'); | ||
| require('skipif_protocol_not_tcp.inc'); | ||
| require('skipif_version_less_than_2k14.inc'); ?> | ||
| --FILE-- |
There was a problem hiding this comment.
maybe put skipif_mid-refactor.inc to the end? because it skips sql server < 2016?
There was a problem hiding this comment.
skipif_mid-refactor doesn't skip any SQL Server unless AE is set, in which case it will skip versions < 2016. That's what we want isn't it?
| <?php require('skipif_unix.inc'); | ||
| <?php require('skipif_mid-refactor.inc'); | ||
| require('skipif_version_less_than_2k14.inc'); ?> | ||
| --FILE-- |
There was a problem hiding this comment.
See my comment earlier about skipif_mid-refactor.inc
| <?php require('skipif_protocol_not_tcp.inc'); | ||
| <?php require('skipif_mid-refactor.inc'); | ||
| require('skipif_protocol_not_tcp.inc'); | ||
| require('skipif_version_less_than_2k14.inc'); ?> |
There was a problem hiding this comment.
same here... otherwise, this test will be skipped even when running against sql server 2014
| <?php require('skipif_protocol_not_tcp.inc'); | ||
| <?php require('skipif_mid-refactor.inc'); | ||
| require('skipif_protocol_not_tcp.inc'); | ||
| require('skipif_version_less_than_2k14.inc'); ?> |
| @@ -1,6 +1,4 @@ | |||
| <?php | |||
| if ( !( strtoupper( substr( php_uname( 's' ),0,3 ) ) === 'WIN' ) ) die( "Skip Test on windows only." ); | |||
|
|
|||
There was a problem hiding this comment.
Does this one and the equivalent one for 2k14 need to check ODBC version? only works for 17.2 right?
| --SKIPIF-- | ||
| <?php require('skipif.inc'); | ||
| require('skipif_unix.phpt'); | ||
| require('skipif_version_less_than_2k16.inc'); ?> |
There was a problem hiding this comment.
I think starting with ODBC 17 Azure AD works outside Windows too.
|
For some reason it's called $DriverName in MsSetup.inc instead of $driver. I'll fix it. |
|
@david-puglielli $DriverName is only in pdo's MsSetup.inc, and I don't know what its use for. |
4 participants
… 17.2
This change is