Support setting flow control limits for individual stream types#3948
Merged
nibanks merged 6 commits intomicrosoft:mainfrom Oct 31, 2023
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (!Settings->IsSet.StreamRecvWindowBidiLocalDefault) { | ||
| ValueLen = sizeof(Settings->StreamRecvWindowBidiLocalDefault); | ||
| CxPlatStorageReadValue( |
Check warning
Code scanning / CodeQL
Expression has no effect
|
|
||
| if (!Settings->IsSet.StreamRecvWindowBidiRemoteDefault) { | ||
| ValueLen = sizeof(Settings->StreamRecvWindowBidiRemoteDefault); | ||
| CxPlatStorageReadValue( |
Check warning
Code scanning / CodeQL
Expression has no effect
|
|
||
| if (!Settings->IsSet.StreamRecvWindowUnidiDefault) { | ||
| ValueLen = sizeof(Settings->StreamRecvWindowUnidiDefault); | ||
| CxPlatStorageReadValue( |
Check warning
Code scanning / CodeQL
Expression has no effect
nibanks
reviewed
Oct 30, 2023
Collaborator
nibanks
left a comment
nibanks
left a comment
There was a problem hiding this comment.
We need to add a new test case on top of MsQuic API to make sure things work as expected.
Codecov Report
@@ Coverage Diff @@
## main #3948 +/- ##
==========================================
+ Coverage 86.88% 87.25% +0.36%
==========================================
Files 56 56
Lines 16901 16958 +57
==========================================
+ Hits 14684 14796 +112
+ Misses 2217 2162 -55
|
Member
Author
|
@nibanks The PR should be ready for another round of review |
nibanks
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3897.
Description
This PR adds 3 new QUIC_SETTINGS members:
With the semantic that if those are set, then they overwrite the StreamRecvWindowDefault setting.
This should preserve backwards compatibility since StreamRecvWindowDefault setting still has effect, but new apps can use the new settings to specify more granular limits.
Testing
Tests in SettingsTests.cpp were updated. I will also verify the change once I managed to write a test app against it.
Documentation
Documentation files were updated.