added KRNN and Sandwich models and their example results based on Alpha360#1414
Merged
you-n-g merged 23 commits intomicrosoft:mainfrom May 26, 2023
Merged
added KRNN and Sandwich models and their example results based on Alpha360#1414you-n-g merged 23 commits intomicrosoft:mainfrom
you-n-g merged 23 commits intomicrosoft:mainfrom
Conversation
updated the result of KRNN and Sandwich models based on Alpha360
github-actions
bot
added
documentation
Contributor
Author
|
@microsoft-github-policy-service agree [company="MSRA"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="MSRA" |
Contributor
Author
|
Contributor License Agreement installed |
Contributor
Author
|
@microsoft-github-policy-service agree company="MSRA" |
you-n-g
requested changes
Apr 14, 2023
| return y | ||
|
|
||
|
|
||
| class KRNNEncoderBase(nn.Module): |
Collaborator
There was a problem hiding this comment.
Why we have 2 same KRNNEncoderBase in the code?
| return hids | ||
|
|
||
|
|
||
| class CNNKRNNEncoder(nn.Module): |
Collaborator
There was a problem hiding this comment.
CNNKRNNEncoder have two similar version as well.
Please merge them
gaogen123
pushed a commit
to gaogen123/qlib
that referenced
this pull request
Sep 13, 2025
…ha360 (microsoft#1414) * Update README.md updated the result of KRNN and Sandwich models based on Alpha360 * Update README.md * Update README.md * Add files via upload * Update README.md * Update README.md * Update README.md * Add files via upload * Delete pytorch_krnn.py * Delete pytorch_sandwich.py * Add files via upload * Update pytorch_sandwich.py * Update pytorch_krnn.py * Update pytorch_sandwich.py * Update pytorch_krnn.py * Update README.md * Update README.md * Update requirements.txt * Update requirements.txt * Update README.md * Update README.md * Update pytorch_sandwich.py * Update link on index --------- Co-authored-by: Young <afe.young@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes