Merged
Conversation
talregev
reviewed
Jul 16, 2025
| if(NOT VCPKG_BUILD_TYPE) | ||
| vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/debug/lib/pkgconfig/wolfssl.pc" "Libs.private: " "Libs.private: -framework CoreFoundation -framework Security ") | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Thanks @talregev! Made a PR, let me know if it fixes it: curl/curl#17945
Contributor
There was a problem hiding this comment.
You are welcome. I don't have apple devices to test it.
There was a problem hiding this comment.
I could replicate the issue with a local static wolfSSL built and confirm the patch fixing it. Also it seems m and dl are not necessary for Apple builds.
This was referenced Jul 17, 2025
vicroms
approved these changes
Jul 17, 2025
vicroms
added
category:port-update
vszakats
added a commit
to curl/curl
that referenced
this pull request
Jul 17, 2025
To fix linking a static wolfSSL library for Apple targets. Also stop linking `m` and `dl` on Apple platforms. Matching logic in wolfSSL build code: https://github.com/wolfSSL/wolfssl/blob/8bde512676fd425d72682fa020362eb9916476ad/CMakeLists.txt#L2520-L2544 Reported-by: Kai Pastor Reported-by: Tal Regev Bug: microsoft/vcpkg#46444 (review) Ref: microsoft/vcpkg@3a845c4 Closes #17945
talregev
pushed a commit
to talregev/vcpkg
that referenced
this pull request
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sectransp removed by upstream. Using openssl as default for ios and osx now.
wolfssl: Add transitive usage requirements to pc file.
https://github.com/wolfSSL/wolfssl/blob/2c90d1585a22986cc4ad9537cef3abb995937c23/IDE/apple-universal/README.md?plain=1#L121-L122