Merged
Conversation
add status bar item to RunLineInEditor class add execution timing to RunLineInEditor class
chrmarti
requested changes
Jun 25, 2019
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the update. Please see my inline comments.
Contributor
|
Testing revealed that the code would fail replacing content when the editor is already hidden by the next one. I'm adding a change to use WorkspaceEdit to cover that case. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and separate code based on @chrmarti comments on my original PR (#47).
This PR adds the user setting & implementation to open command results in separate tabs.