This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Fix break-on-load to make breakpoints on attach work#332
Merged
roblourens merged 5 commits intomicrosoft:masterfrom Sep 26, 2018
Merged
Fix break-on-load to make breakpoints on attach work#332roblourens merged 5 commits intomicrosoft:masterfrom
roblourens merged 5 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@rakatyal PTAL |
Member
|
Is this still valid? Are you going to review it @rakatyal? |
Contributor
|
@roblourens: Yes I believe this is still valid but we are not planning to ship this at the moment. I will review this soon. |
Contributor
Author
|
@roblourens @rakatyal We are planning on using this PR for VS 16. Could you please review it now? |
Member
|
@rakatyal are you going to review this? |
Contributor
|
@roblourens: Yes I will do this today. Apologies for missing this earlier. |
rakatyal
reviewed
Sep 26, 2018
| suite('break-on-load', () => { | ||
| test('is active when the parameter is specified and we are launching', async () => { | ||
| await chromeDebugAdapter.launch({breakOnLoadStrategy: 'regex'}); | ||
| assert(chromeDebugAdapter.breakOnLoadActive, 'Break on load should we active if we pass the proper parameter and we are attaching'); |
rakatyal
reviewed
Sep 26, 2018
|
|
||
| test('is active when the parameter is specified and we are attaching', async () => { | ||
| await chromeDebugAdapter.attach({breakOnLoadStrategy: 'regex', port: ATTACH_SUCCESS_PORT}); | ||
| assert(chromeDebugAdapter.breakOnLoadActive, 'Break on load should we active if we pass the proper parameter and we are attaching'); |
rakatyal
approved these changes
Sep 26, 2018
roblourens
approved these changes
Sep 26, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Thanks for the PR and for including so many tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This as final bug-fixes. At this moment we are using this change as a temporary-workaround to fix the NTVS unit tests