This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Added support for basic color escape sequencies on Debug Console#367
Merged
roblourens merged 3 commits intomicrosoft:masterfrom Oct 17, 2018
rdegelo:master
Merged
Added support for basic color escape sequencies on Debug Console#367roblourens merged 3 commits intomicrosoft:masterfrom rdegelo:master
roblourens merged 3 commits intomicrosoft:masterfrom
rdegelo:master
Conversation
Added support for bold font style on Debug Console
Contributor
Author
|
Related to issue: Microsoft/vscode-chrome-debug#282 |
Member
|
This looks great, but the font-weight doesn't appear to have any affect in the Debug Console. Is it working for you? I don't know whether vscode supports it. |
Contributor
Author
|
It works for me: To check what is supported, you can see this file: |
Member
|
I see it, the problem is that the debug console uses the Monaco font on macos, which doesn't support a bold font weight. Will take that upstream... |
Contributor
Author
|
Cool, |
roblourens
approved these changes
Oct 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added support for bold font style on Debug Console.
Background color can be easily implemented using the same approach.
If this PR gets accepted, I can add background colors support.