This repository was archived by the owner on Oct 2, 2021. It is now read-only.
Improving Debug Console Styling. Adding underline and background support#374
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Oct 29, 2018
Merged
Improving Debug Console Styling. Adding underline and background support#374roblourens merged 1 commit intomicrosoft:masterfrom
roblourens merged 1 commit intomicrosoft:masterfrom
Conversation
roblourens
reviewed
Oct 29, 2018
| // value:"color: gray; font-weight: light | ||
| const colorMatches = colorRegex.exec(arg.value); | ||
| const fontWeightMatches = fontWeightRegex.exec(arg.value); | ||
| const cssRegex = /\s*(.*?)\s*:\s*(.*?)\s*(?:;|$)/g; |
Member
There was a problem hiding this comment.
Isn't the .*? redundant or is that different than .*?
Contributor
Author
There was a problem hiding this comment.
Its not, * is greedy by default, and will try to match as much text as possible and will eventually match multiple parameters. ? makes it lazy.
test: aaaa; test2: bbbbb;
If ? gets removed, the first match on this text will be the whole string, and that's not what we want.
Member
There was a problem hiding this comment.
Oh, didn't know that, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.