Fix reference error issue when setting a new value for property

[ahmadov]

Fix microsoft/vscode-node-debug2#250

[roblourens]

FYI @EricCornelson it looks like the $s disappeared when moving this code to its own class.

[roblourens]

Thanks, I would rather keep it the way it was before using ${}. I assume that if we pass strings to the "arguments" here, they would always be interpreted as strings.

[ahmadov]

Yes, first I wanted to just add the missing ${} but then I realized the type of the value argument is already a string. So, If we put the missing $, the function would be like that: this[...] = ${value} and putting $ is not enough because if the value is "foo" the result will be this[...] = foo which is also undefined.

The way to solve that issue is surrounding the ${value} with double-quotes such as this[...] = "${value}" and in that case, it'd be always interpreted as strings.

I followed the other way because Chrome also uses the way "arguments". I think the underlying problem is type of the value is always a string.

[ahmadov]

Hi @roblourens,
I got your point and changed the code back to ${} as it was before.

[roblourens]

Thanks!