Fix pseudo-element specificity#154
Merged
aeschli merged 7 commits intomicrosoft:masterfrom Jun 12, 2019
parzh:fix-pseudo-element-specificity
Merged
Fix pseudo-element specificity#154aeschli merged 7 commits intomicrosoft:masterfrom parzh:fix-pseudo-element-specificity
aeschli merged 7 commits intomicrosoft:masterfrom
parzh:fix-pseudo-element-specificity
Conversation
Collaborator
|
Thanks @parzh . I modified the RP a bit in order to keep the changes minimal. I hope that's ok for you. |
Author
|
@aeschli Thanks for the merge! Yes, that's fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See microsoft/vscode#72608 (comment) for a quick reference
In CSS3, pseudo-classes (such as
:hover,:focus, or:invalid) and pseudo-elements (such as::before,::afteretc.) have some noticeable differences::, while pseudo-elements start with::(though for backwards compatibility this is not enforced);Currently, they are being distinguished by amount of semicolons, which produces incorrect results when encountering backwards-compatible code:
Specificity here is expected to be
(0, 0, 3), but got(0, 1, 2). That's because pseudo-element was incorrectly parsed as pseudo-class.Here the number of colons (
::) corresponds to the entity type (pseudo-element), so the specificity is displayed correctly.This PR fixes this issue.