Skip to content

Add some plurals to command reference#3379

Merged
gregvanl merged 1 commit intomicrosoft:masterfrom
brettcannon:patch-5
Feb 3, 2020
Merged

Add some plurals to command reference#3379
gregvanl merged 1 commit intomicrosoft:masterfrom
brettcannon:patch-5

Conversation

@brettcannon
Copy link
Member

There also might be other places where "all" and plurality is called for (i.e. other commands that return arrays), but without knowing whether that means multiple providers are called or a single provider with multiple values is returned I didn't want to be presumptuous and get it wrong.

There also might be other places where "all" and plurality is called for (i.e. other commands that return arrays), but without knowing whether that means multiple providers are called or a single provider with multiple values is returned I didn't want to be presumptuous.
@gregvanl gregvanl merged commit eef5f85 into microsoft:master Feb 3, 2020
@gregvanl
Copy link

gregvanl commented Feb 3, 2020

Thanks

@gregvanl
Copy link

gregvanl commented Feb 3, 2020

These are auto-generated from product comments, but I can port the corrections back to the vscode repo.

brettcannon added a commit to brettcannon/vscode that referenced this pull request Feb 3, 2020
@brettcannon
Copy link
Member Author

I opened microsoft/vscode#89959 to fix this upstream.

@brettcannon brettcannon deleted the patch-5 branch February 3, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants