Automatically use mypy.ini or pyproject.toml when not in the root directory of the workspace

[theomessin]

When using the Mypy linter, our standard is to have a mypy.ini in the project's root with a bunch of config values. Currently we have our developers use this setting for vscode:

  "python.linting.mypyArgs": [
    "--config-file=${workspaceFolder}/mypy.ini"
  ]

However, if a project doesn't have a mypy.ini file linting fails silently (which can cause a lot of issues as a dev might think that mypy worked fine).

I think that auto-detecting and using the mypy.ini file should be a part of the plugin itself.

[brettcannon]

https://mypy.readthedocs.io/en/latest/config_file.html#the-mypy-configuration-file suggests the configuration file is detected automatically by mypy and so the extension shouldn't have to do anything special. Or am I misunderstanding what you're asking for?

[theomessin]

However, mypy will auto-detect mypy.ini "in the current directory". The extension calls mypy on each file, whereas you'd normally just call it for all files from the project root, right?

[brettcannon]

@theomessin ah, gotcha. And since mypy doesn't walk up the directory hierarchy looking for a config it won't find it if you're linting a file in a subdirectory.

Please do consider upvoting microsoft/vscode-python#1577 as that's probably going to be the easiest way to see this resolved.

[KholdStare]

Any updates?

[ssbarnea]

@brettcannon With the PEP-621 migration, mypy is also able to read pyproject.toml and my impression is that it it does load it.

Maybe we should rename this ticket into "mypy-plugin support should load config from same default locations as mypy itself, without requiring any configuration"

[KholdStare]

@ssbarnea We have a usecase where we don't store the mypy settings in pyproject.toml, but in .mypy.ini in the project directory. We have a monorepo with several python projects and are using vscode's multiroot workspace. All these python projects share the same mypy settings, and the only way we could reduce duplication (no copy pasting in all the pyproject.toml files) is to symlink a "master" .mypy.ini into all the subprojects.

Currently we have to do this to make mypy work:

  "python.linting.mypyArgs": [
    "--config-file=${workspaceFolder}/.mypy.ini"
  ]

[brettcannon]

Maybe we should rename this ticket

I renamed it to try to make it clearer while keeping some keywords in it to facilitate searching.