Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Stop debugging on program end#112

Merged
roblourens merged 2 commits intomicrosoft:masterfrom
rianadon:master
Jun 19, 2017
Merged

Stop debugging on program end#112
roblourens merged 2 commits intomicrosoft:masterfrom
rianadon:master

Conversation

@rianadon
Copy link
Contributor

This fixes #11 and re-enables the test for it.

Thanks for your help @roblourens!

@msftclas
Copy link

@rianadon,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@rianadon, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@roblourens
Copy link
Member

Perfect, thanks!

@roblourens roblourens merged commit 4b9f1f3 into microsoft:master Jun 19, 2017
flovilmart added a commit to flovilmart/vscode-jasmine-test-adapter that referenced this pull request Jun 30, 2018
Theres a known issue in node < 8 where the debugger wont detach

microsoft/vscode-node-debug2#112
flovilmart added a commit to flovilmart/vscode-jasmine-test-adapter that referenced this pull request Jun 30, 2018
Theres a known issue in node < 8 where the debugger wont detach

microsoft/vscode-node-debug2#112
flovilmart added a commit to flovilmart/vscode-jasmine-test-adapter that referenced this pull request Jul 1, 2018
Theres a known issue in node < 8 where the debugger wont detach

microsoft/vscode-node-debug2#112
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debugger can't terminate on program end

3 participants