Removed TSLint recommendation and mentions left#2758
Merged
alexr00 merged 2 commits intomicrosoft:mainfrom Jun 3, 2021
Merged
Conversation
alexr00
approved these changes
Jun 3, 2021
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thanks for making this update!
Member
Probably not intentional. I'll look at adding them. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2757
@eamodio did amzaing job in migrating TSLint to ESLint in #2518 and I was a bit suprised when on another PC I've got recommndation to install TSLint extension for this repo.
This PR changes recommended extension from TSLint to ESLint.
Also removes last mentions on TSLint:
@typescript-eslint/no-unused-expressionsnor@typescript-eslint/no-unused-expressionshandle construstions withnew)tslint.jsonis no longer in repoPlease let me know if last commit should be removed from PR
P.S. Is it intentional that lint checks are not included in PR builds?