fix: make pending checks "show" button / link accessible#2972
Merged
alexr00 merged 1 commit intomicrosoft:mainfrom Sep 1, 2021
Merged
fix: make pending checks "show" button / link accessible#2972alexr00 merged 1 commit intomicrosoft:mainfrom
alexr00 merged 1 commit intomicrosoft:mainfrom
Conversation
More info: https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/mouse-and-keyboard-events/links/link-behavior/#:~:text=Do%20not%20use%20an%20anchor%20with%20an%20onclick%20event%20without%20an%20href%20element%20event. A note: It would be better to use `button` element here and style it as link but this is a quick fix.
moshfeu
changed the title
alexr00
approved these changes
Aug 30, 2021
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thanks for the fix! I will merge in the next couple days after we have made our August release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2973
More info
A note: It would be better to use
buttonelement here and style it as link but this is a quick fix.