Comments don't show when PR is on non-default repo#8126
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces reference counting for commenting range providers and fixes the comment controller ID generation to include remote names, addressing potential conflicts when multiple remotes point to the same repository.
Key changes:
- Implements reference counting for
CommentingRangeProvider2instances to prevent premature disposal - Updates comment controller ID to include
remoteNamefor better uniqueness - Moves
await this.ensure()before the early return check inensureCommentsController()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/view/pullRequestCommentControllerRegistry.ts | Adds PRCommentingRangeProviderInfo interface with reference counting, updates provider registration/disposal logic to match the existing pattern used for comment handlers |
| src/github/githubRepository.ts | Adds remoteName to comment controller ID and reorders initialization to ensure proper setup before early return |
Tyriar
approved these changes
Nov 10, 2025
Comment on lines
+23
to
+27
| interface PRCommentingRangeProviderInfo { | ||
| provider: vscode.CommentingRangeProvider2; | ||
| refCount: number; | ||
| dispose: () => void; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8050