Do not create notifications for copilot PRs which are in progress#8381
Merged
Do not create notifications for copilot PRs which are in progress#8381
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent notifications from being created for Copilot PRs that are in progress (i.e., have a "Started" status), addressing issue #8380.
Key Changes
- Added a check in
CopilotStateModel.set()to skip notification creation for PRs with Started status - State changes are still tracked, but notifications are suppressed for in-progress PRs
Comments suppressed due to low confidence (1)
src/github/copilotPrWatcher.ts:74
- This change modifies existing notification behavior. The existing test at line 61-63 in copilotPrWatcher.test.ts expects notifications to be created when a PR status changes to Started after initialization. This breaking change requires updating the test expectations to reflect the new behavior where Started status should not generate notifications.
if ((currentStatus?.status === CopilotPRStatus.Started)) {
continue;
}
|
Does AI have good points here? Also CI is failing... |
Tyriar
previously approved these changes
Jan 9, 2026
alexr00
commented
Jan 9, 2026
Member
Author
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Copilot feedback was legit.
dmitrivMS
previously approved these changes
Jan 9, 2026
Tyriar
approved these changes
Jan 9, 2026
Member
Author
|
@microsoft-github-policy-service rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8380