Skip to content

Support GitHub Issue Links#345

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
HaaLeo:master
Jul 11, 2019
Merged

Support GitHub Issue Links#345
joaomoreno merged 2 commits intomicrosoft:masterfrom
HaaLeo:master

Conversation

@HaaLeo
Copy link
Contributor

@HaaLeo HaaLeo commented May 7, 2019

Related Issues

Closes #340:

Changes

  • Enable to replace GitHub issue references with absolute urls
    • Supports to replace issue links of shape #7 as well as Microsoft/vscode#7
  • Do not replace anything if it is no GitHub repository
  • Added unit tests

There is no conflict between issues and pull requests because GitHub redirects issue urls automatically to prs. For example: https://github.com/microsoft/vscode-vsce/issues/248 will be redirected to https://github.com/microsoft/vscode-vsce/pulls/248

If you have any questions, do not hestiate to ask me.

HaaLeo added 2 commits May 7, 2019 15:34
* Enable to replace GitHub issue references with absolute urls
* Do not replace anything if it is no GitHub repository
@msftclas
Copy link

msftclas commented May 7, 2019

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno self-assigned this May 7, 2019
@hbjydev
Copy link

hbjydev commented May 9, 2019

This looks like a really cool feature, well done

@joaomoreno joaomoreno added this to the Backlog milestone May 23, 2019
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label May 23, 2019
@HaaLeo
Copy link
Contributor Author

HaaLeo commented Jul 9, 2019

@joaomoreno Any chance to get this one in soon? 🙂 🚀

@joaomoreno joaomoreno merged commit d999140 into microsoft:master Jul 11, 2019
@joaomoreno
Copy link
Member

This is pretty cool, thanks!

@joaomoreno joaomoreno modified the milestones: Backlog, July 2019 Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support GitHub Issue Links

4 participants