Skip to content

Honors --yarn flag for prepublish step#376

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
eamodio:prepublish-yarn
Jul 23, 2019
Merged

Honors --yarn flag for prepublish step#376
joaomoreno merged 1 commit intomicrosoft:masterfrom
eamodio:prepublish-yarn

Conversation

@eamodio
Copy link
Contributor

@eamodio eamodio commented Jul 19, 2019

Uses yarn for the prepublish step if --yarn is specified on the command line

/cc @joaomoreno

@eamodio
Copy link
Contributor Author

eamodio commented Jul 19, 2019

FYI, this change has a pretty big performance improvement for package/publish (at least for GitLens)

@eamodio
Copy link
Contributor Author

eamodio commented Jul 22, 2019

@joaomoreno any chance of something like this landing soon? Without it, packaging GitLens takes ~180s rather than ~68s. So I've been regularly hand patching it -- which is annoying because I wipe out node_modules before packaging 😄

@joaomoreno
Copy link
Member

joaomoreno commented Jul 23, 2019

Right now! Thanks!

Released in v1.66.0, builds are running https://dev.azure.com/vscode/VSCE/_build/results?buildId=23527

@joaomoreno joaomoreno added this to the July 2019 milestone Jul 23, 2019
@joaomoreno joaomoreno self-assigned this Jul 23, 2019
@joaomoreno joaomoreno merged commit 188c304 into microsoft:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants