Skip to content

Support injecting PAT from an environmental variable#447

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
owenfarrell:environmental-pat
May 12, 2020
Merged

Support injecting PAT from an environmental variable#447
joaomoreno merged 1 commit intomicrosoft:masterfrom
owenfarrell:environmental-pat

Conversation

@owenfarrell
Copy link
Contributor

This change adds a default value to the -p (--pat) option for the publish command based on an environmental variable.

Making this change creates an implicit default value for providing a personal access token, making it easier to trigger VSCE releases from CI platforms where global installation of modules is not possible (i.e. publish a VSCE extension via an npm run... command).

@joaomoreno
Copy link
Member

joaomoreno commented May 12, 2020

I love it, thanks! Great implementation, also! 🔥

@joaomoreno joaomoreno merged commit ba42d4c into microsoft:master May 12, 2020
@joaomoreno joaomoreno self-assigned this May 12, 2020
@joaomoreno joaomoreno added this to the May 2020 milestone May 12, 2020
@owenfarrell owenfarrell deleted the environmental-pat branch May 12, 2020 14:29
tejanium added a commit to tejanium/vscode-blame-pr that referenced this pull request Jun 8, 2020
VCSE now support injecting PAT from an environmental variable
microsoft/vscode-vsce#447
tejanium added a commit to tejanium/vscode-blame-pr that referenced this pull request Jun 8, 2020
VCSE now support injecting PAT from an environmental variable
microsoft/vscode-vsce#447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants