code cannot start with AFS homedir

[zao]

• VSCode Version: 1.10.2 (code_1.10.2-1488981323_amd64.deb)
• OS Version: Ubuntu 16.04 LTS

Steps to Reproduce:

1. Have home directory w/ .config on AFS.
2. Run code --verbose.
3. Get the following error:

Error: listen EPERM /home/l/lars/.config/Code/1.10.2-main.sock
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at Server._listen2 (net.js:1240:19)
    at listen (net.js:1289:10)
    at Server.listen (net.js:1378:5)
    at /usr/share/code/resources/app/out/vs/code/electron-main/main.js:7:11235
    at new n.Class.derive._oncancel (/usr/share/code/resources/app/out/vs/code/electron-main/main.js:6:13143)
    at Object.p [as serve] (/usr/share/code/resources/app/out/vs/code/electron-main/main.js:7:11165)
    at o (/usr/share/code/resources/app/out/vs/code/electron-main/main.js:13:9918)
    at te (/usr/share/code/resources/app/out/vs/code/electron-main/main.js:13:10989)

Code starts normally if moving the .config/Code directory to a local filesystem and symlinking it in. I would reckon that it's probably not portable to put the kind of thing that 1.10.2-main.sock is in the homedir, as it may very well be mounted in fun ways or on network filesystems.

This behaviour is new since the previous release I ran, which I believe was code_1.9.1-1486597190_amd64.deb.

[zao]

Squinting at the XDG Base Directory Specification it seems like sockets and other runtime files shall be created in XDG_RUNTIME_DIR, which on my system is down in /run/user/3121.

[joaomoreno]

Not sure what to do here. Best I can do is to recommend not using AFS. Does it support socket files?

[zao]

I don't have any choice in AFS for my home directory where the default XDG config directory is located. Sure I could point the config elsewhere, but then I'd lose access to the same configuration across machines which is the whole point of a shared homedir.

AFS doesn't support named pipes in the filesystem intentionally as it's a distributed filesystem and the semantics for how they would work across the world is hard to pin down.

As far as I interpret the XDG specification, you should not use the config directory for runtime state. They explicitly mention the runtime dir for that.
I don't know where in the stack this is done, but it's quite wrong to use the possibly shared homedir for machine-local state.

$XDG_RUNTIME_DIR supports things like mkfifo's named pipes

[joaomoreno]

Got it, thanks.

[gdamjan]

the same thing for the socket files in /tmp/ like /tmp/vscode-9106d11a-a2f2-4ba7-8e8c-269c06c6710f.sock= they should go in $XDG_RUNTIME_DIR (if available, if not /tmp is ok).

the added benefit of $XDG_RUNTIME_DIR is it goes away when the user logs out.

[ishanarora]

The same issue appears with sshfs mounted home directory