Find in Files "files to include" override .gitignore

[borekb]

VSCode 1.12: I have a TypeScript project with a src folder and a .gitignore file containing this:

/src/**/*.js

If I search for something, it is OK with 'files to include' is empty:

but it is not OK if I scope the search:

While I'm searching only in some sup-tree of my project, all .gitignore rules should still be taken into account.

[roblourens]

It seems like ripgrep will let include globs override entries in the gitignore file. I'm not sure whether that's expected or whether we can change that. But one workaround is to use ./src syntax in 'files to include'.

[kompot]

./src seems to be broken again - regardless of syntax put to files to include .gitignore is no longer respected by ripgrep. I'm pretty sure it worked before, maybe ripgrep API change?

[roblourens]

Unfortunately that's because I changed it to not use gitignore files in parent directories which breaks that workaround.

[kompot]

This was working OK up to version 1.30.
1.31 broke this.

[roblourens]

Can you explain what you mean by "this"? This issue has been open for a long time.

[roblourens]

Sorry I see, the workaround I mentioned above will not work anymore. The only suggestion I have right now is to add patterns to search.exclude as well. I'll have to figure out why ripgrep handles gitignore patterns differently.

[kompot]

Seems like it's discussed in this ripgrep issue
BurntSushi/ripgrep#829

UPD
and there's even an unmerged PR
BurntSushi/ripgrep#963

[roblourens]

I can't tell whether that's the right issue or not. vscode does not invoke rg with a path argument, the ./ syntax is converted to glob patterns.

[kompot]

Right now I observe this bug/feature/behaviour both in vscode and in rg console output.

I have a file at path front/build/1.html. It contains string xxx. Directory front/build is gitignored.

rg xxx from project root finds nothing
rg xxx -g "front/**/*" finds xxx

same happens in vscode

searching with files to include being empty finds nothing
searching with ./front in files to include finds xxx

As a proposal: maybe vscode should always search from root and filter with files to include afterwards in memory just for UI. More work but it's near instant with ripgrep anyway.