Wrong git decorations in file explorer

[LaurentTreguier]

• VSCode Version: 1.18.0
• OS Version: Fedora 26 x86_64

Steps to Reproduce:

1. Add some files in a git repository
2. Modify the .gitignore to ignore a certain pattern, andadd exceptions to this pattern

Extract from my .gitignore:

.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json

Result:

You can see that .vscode/tasks.json is grayed out because it matches .vscode/*, even if it shouldn't because of the !.vscode/tasks.json rule. However, it still has the correct U badge for some reason.
The file probably isn't supposed to be grayed out, since git does take it into account.

[jrieken]

From the command line, can you run this git check-ignore .vscode/tasks.json and post the output here?

[LaurentTreguier]

$ git check-ignore .vscode/tasks.json
.vscode/tasks.json

It looks like it's actually being ignored by git... But when using git status:

$ git status
[...]
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	.vscode/
	README.md
	dub.selections.json
	source/dls/util/uri.d

no changes added to commit (use "git add" and/or "git commit -a")

Here it considers .vscode/ as untracked (it only contains tasks.json, removing !.vscode/tasks.json from .gitignore makes git status ignore .vscode/). So git is being a bit inconsistent here...

[jrieken]

But the .vscode/task.json files doesn't show up in the git viewlet, right? That's the model we use to decide on the modified and untracked/added state.

[LaurentTreguier]

Yes it does, it shows up in the git viewlet:

And just like in the explorer, the badge is U but it's grayed out.

[jrieken]

@joaomoreno Can you help? Is this a valid git state?

[joaomoreno]

Yup, it appears git check-ignore has a bug.

Seems to be exactly this: https://marc.info/?l=git&m=150904377104805&w=2

Related: https://marc.info/?l=git&m=150143026024244&w=2