Support opening text document with provided visible ranges from diff editor

[ajackson-cpi]

Issue Type: Bug

When viewing a Source Code Management (git) diff editor, I scroll to the interesting areas. But when I click "Open File" to be rid of the left-side view, I'm reset to the top of the file.

Though minor, its impact is significant: I'm usually thinking about the change to be made, not about file navigation. This causes confusion by kicking me out of the solution mindset and into trying to re-discover the code area.

VS Code version: Code 1.24.1 (24f6262, 2018-06-13T17:41:50.128Z)
OS version: Darwin x64 17.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 16, 23
Memory (System)	16.00GB (0.80GB free)
Process Argv	/Applications/Visual Studio Code.app/Contents/MacOS/Electron -psn_0_2826930
Screen Reader	no
VM	0%

Extensions (13)

Extension	Author (truncated)	Version
ng-template	Ang	0.1.9
vscode-docker	Pet	0.0.27
vscode-database	baj	1.5.1
gitlens	eam	8.4.1
Angular2	joh	6.1.1
vscode-sshfs	Kel	1.9.2
atom-keybindings	ms-	3.0.4
Go	ms-	0.6.84
vetur	oct	0.12.5
remote-vscode	raf	1.1.0
vscode-redis	vit	1.2.0
vscode-todo-highlight	way	0.5.12
vscode-proto3	zxh	0.2.1

[joaomoreno]

Does this work for you if you set a cursor/selection before switching editors?

[ajackson-cpi]

Yes, Setting a cursor location does resolve it.

[mnikn]

want to contribute on this issue, has someone handled it before?

[mnikn]

@ajackson-cpi what if you set a cursor location first, then you scroll to another area, which position you expect when you open this file? the cursor location or the scroll area?

[ajackson-cpi]

My preference is that both the cursor and the scroll location are preserved thereby resembling the left-side of the diff being closed and the right side being unchanged.
Today only the cursor position is preserved and the scroll is re-centered onto it.