Extensions search bar is emptied when reloading window

[dfoverdx]

Issue Type: Bug

1. Open Extensions in Side Bar
2. Type something in search bar (e.g. @installed javascript)
3. Reload window (F1+reload window+Enter)
4. Extensions search bar is now empty.

It would be helpful if the search bar in the Extensions Side Bar maintained its value when reloading the window. Frequently when I don't know which extension is causing adverse behavior, I make a guess at which extensions it might be (e.g. @installed css), disable one, click Reload, check whether it worked or not, and repeat. I find it frustrating that I have to type @installed css each time.

VS Code version: Code 1.29.1 (bc24f98, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz (6 x 2808)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	15.94GB (9.24GB free)
Process Argv
Screen Reader	no
VM	0%

[vldmrkl]

@sandy081 do you work on this issue? If you don't, I'd like to work on it.

[sandy081]

@klymenkoo Please go ahead and submit PR and I would be happy to look at it. Thanks.

[vldmrkl]

@sandy081 after exploring the code, it seems to me that extensionsViewlet needs to implement viewletState in order to keep track of value of searchBox input. I looked at workbench search feature as it keeps value of the input after reloading window, and it seems it has viewletState which holds the value of input.

Can you confirm? Am I on the right way?

[sandy081]

@klymenkoo Yes you are.

[sandy081]

This is supported now.